Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove CalcDepositorFeeV1 once the upgrade height DynamicDepositorFeeHeightV2 is reached #2766

Closed
Tracked by #2760
ws4charlie opened this issue Aug 23, 2024 · 0 comments · Fixed by #2899
Closed
Tracked by #2760

chore: remove CalcDepositorFeeV1 once the upgrade height DynamicDepositorFeeHeightV2 is reached #2766

ws4charlie opened this issue Aug 23, 2024 · 0 comments · Fixed by #2899
Assignees
@ws4charlie
Labels
chain:bitcoin Bitcoin chain related code-quality Code quality improvement zetaclient Issues related to ZetaClient

Comments

@ws4charlie
Copy link
Contributor

Describe the Issue
Clean up the usage of CalcDepositorFeeV1 in code base once upgrade height DynamicDepositorFeeHeightV2 is reached.

In the future, we only use CalcDepositorFeeV2 introduced by PR #2765

Expected Outcome
A description of what outcome you are seeking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ws4charlie ws4charlie

Labels
chain:bitcoin Bitcoin chain related code-quality Code quality improvement zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove btc deposit fee v1 and improve unit tests zeta-chain/node
1 participant
@ws4charlie