Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bitcoin with Protocol contract v2 architecture #2711

Open
Tracked by #2745
lumtis opened this issue Aug 15, 2024 · 0 comments
Open
Tracked by #2745

Support Bitcoin with Protocol contract v2 architecture #2711

lumtis opened this issue Aug 15, 2024 · 0 comments
Assignees
Labels
chain:bitcoin Bitcoin chain related zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Aug 15, 2024

Describe the Issue

  • Define some logic allow to set ProtocolContractVersions == 2 in the vote inbound in inbound.go
  • Set the correct message: the message passed in VoteInbound is not the message itself, it doesn't contains the receiver as first few bytes anymore, this parsing should be done at the ZetaClient level
  • Add E2E test to check Deposit and DepositAndCall

IMPORTANT: Bitcoin should still use the Origin field for the context for calls has the sender field (ethaddress) can't contains the address : #3018 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chain:bitcoin Bitcoin chain related zetaclient Issues related to ZetaClient
Projects
None yet
Development

No branches or pull requests

1 participant