Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit EVM related event when synthetic EVM tx revert #2461

Closed
lumtis opened this issue Jul 11, 2024 · 1 comment · Fixed by #2466
Closed

Emit EVM related event when synthetic EVM tx revert #2461

lumtis opened this issue Jul 11, 2024 · 1 comment · Fixed by #2466
Assignees
Labels
bug Something isn't working m:fungible
Milestone

Comments

@lumtis
Copy link
Member

lumtis commented Jul 11, 2024

Describe the Bug

No event to index the EVM transaction is emitted if a synthetic tx revert.

if err != nil {

if res.Failed() {

We should process this same logic when the tx revert to ensure they can be indexed in explorer

if !noEthereumTxEvent {

@lumtis lumtis added bug Something isn't working m:fungible labels Jul 11, 2024
@lumtis lumtis added this to the July milestone Jul 11, 2024
@skosito skosito self-assigned this Jul 11, 2024
@fadeev
Copy link
Member

fadeev commented Jul 15, 2024

Note to self: this is a prerequisite for Tenderly being able to track calls from system contract to universal apps (specifically the ones that have been reverted).

@lumtis lumtis linked a pull request Jul 15, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working m:fungible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants