Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find consistent prefixing for enum used in chains package #2420

Open
lumtis opened this issue Jul 2, 2024 · 0 comments
Open

Find consistent prefixing for enum used in chains package #2420

lumtis opened this issue Jul 2, 2024 · 0 comments
Labels
code-quality Code quality improvement

Comments

@lumtis
Copy link
Member

lumtis commented Jul 2, 2024

Describe the Issue
Context: you can't have duplicated enum values in a protofile: #2416 (comment)

Solution to avoid inconsistent enum values would be tol set consistent prefix between values.

Eventually consider inline enum as a solution.

@lumtis lumtis added the code-quality Code quality improvement label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code quality improvement
Projects
None yet
Development

No branches or pull requests

1 participant