Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: erc20_deposit_and_call_refund failed balance mismatch #2376

Closed
gartnera opened this issue Jun 24, 2024 · 0 comments · Fixed by #2366
Closed

e2e: erc20_deposit_and_call_refund failed balance mismatch #2376

gartnera opened this issue Jun 24, 2024 · 0 comments · Fixed by #2366
Assignees
Labels
bug Something isn't working

Comments

@gartnera
Copy link
Member

gartnera commented Jun 24, 2024

Describe the Bug
We're seeing this failure during the e2e upgrade tests at least four days in a row now:

setup      | ❌ erc20 tests failed: erc20_deposit_and_call_refund failed: expected balance to be 1999999999999926400 after refund; got 1999999999999916400, stack trace goroutine 98 [running]:
github.com/zeta-chain/zetacore/e2e/runner.(*E2ERunner).RunE2ETest.func1()
	/go/delivery/zeta-node/e2e/runner/run.go:27 +0x85
panic({0x2721ea0, 0xc001667360})
	/usr/local/go/src/runtime/panic.go:884 +0x213
github.com/zeta-chain/zetacore/e2e/e2etests.TestERC20DepositAndCallRefund(0xc000dad180, {0x2c02f01?, 0x5027480?, 0xc0016fdae8?})
	/go/delivery/zeta-node/e2e/e2etests/test_erc20_deposit_refund.go:62 +0x1045
github.com/zeta-chain/zetacore/e2e/runner.(*E2ERunner).RunE2ETest(0xc000dad180, {{0x2c2e1d9, 0x1d}, {0x2cce8a4, 0x42}, {0x506ba28, 0x0, 0x0}, {0x506ba28, 0x0, ...}, ...}, ...)
	/go/delivery/zeta-node/e2e/runner/run.go:40 +0x20d
github.com/zeta-chain/zetacore/e2e/runner.(*E2ERunner).RunE2ETests(...)
	/go/delivery/zeta-node/e2e/runner/run.go:12
github.com/zeta-chain/zetacore/cmd/zetae2e/local.erc20TestRoutine.func1()
	/go/delivery/zeta-node/cmd/zetae2e/local/erc20.go:71 +0x531
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
	/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0xa5

setup      | ❌ e2e tests failed after 4m39.436073656s

https://github.com/zeta-chain/node/actions/runs/9631284749/job/26562890163
https://github.com/zeta-chain/node/actions/runs/9631284749/job/26562890163
https://github.com/zeta-chain/node/actions/runs/9623393708/job/26545820473
https://github.com/zeta-chain/node/actions/runs/9609092323/job/26502992592

erc20_deposit_and_call_refund seems to pass before upgrade but fails after the upgrade. I would have expected it to be the other way around since the fungible admin credentials have changed in the new version but not in the old version zetae2e is always the newest version even in the upgrade tests.

Per CI: 5e3c3ba was the last good commit, e6287e2 was the first known bad commit.

Tested good commits:

Appears to have broken by ca9b90f / #2319. After git revert ca9b90f8e953415c4babeea76ecb23848892ac2e, the upgrade tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants