Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PolicyTable for authorization #2247

Closed
Tracked by #2107
kingpinXD opened this issue May 23, 2024 · 0 comments · Fixed by #2319
Closed
Tracked by #2107

Use PolicyTable for authorization #2247

kingpinXD opened this issue May 23, 2024 · 0 comments · Fixed by #2319
Assignees
@kingpinXD
Labels
code-quality Code quality improvement m:authority

Comments

@kingpinXD
Copy link
Contributor

kingpinXD commented May 23, 2024 •
edited
Loading

  • Use the policy table defined in Add PolicyTable to authority module #2246 for authorization. Replace existing IsAuthorized calls with the new function call
  • Replace MockIsAuthorized function with the MockCheckAuthorization call
  • Pass the msg as an argument and to verify the call happens as expected
@kingpinXD kingpinXD mentioned this issue May 23, 2024
Closed
@kingpinXD kingpinXD added m:authority code-quality Code quality improvement labels May 23, 2024
@kingpinXD kingpinXD mentioned this issue Jun 6, 2024
Merged
10 tasks
@lumtis lumtis linked a pull request Jun 20, 2024 that will close this issue
refactor: use CheckAuthorization instead of IsAuthorized #2319
Merged
10 tasks
@lumtis lumtis added code-quality Code quality improvement and removed code-quality Code quality improvement labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingpinXD kingpinXD

Labels
code-quality Code quality improvement m:authority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use CheckAuthorization instead of IsAuthorized zeta-chain/node
2 participants
@lumtis @kingpinXD