From f3f9458acc54afe38e64e7ea8d68ff11fb90b311 Mon Sep 17 00:00:00 2001 From: Charlie Chen Date: Mon, 25 Nov 2024 13:29:28 -0600 Subject: [PATCH] clean up commented test --- zetaclient/chains/solana/rpc/rpc_live_test.go | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/zetaclient/chains/solana/rpc/rpc_live_test.go b/zetaclient/chains/solana/rpc/rpc_live_test.go index 78a4bfad6b..e5d47b7302 100644 --- a/zetaclient/chains/solana/rpc/rpc_live_test.go +++ b/zetaclient/chains/solana/rpc/rpc_live_test.go @@ -8,13 +8,14 @@ import ( solanarpc "github.com/gagliardetto/solana-go/rpc" "github.com/stretchr/testify/require" "github.com/zeta-chain/node/zetaclient/chains/solana/rpc" + "github.com/zeta-chain/node/zetaclient/common" ) // Test_SolanaRPCLive is a phony test to run all live tests func Test_SolanaRPCLive(t *testing.T) { - //if !common.LiveTestEnabled() { - // return - //} + if !common.LiveTestEnabled() { + return + } LiveTest_GetTransactionWithVersion(t) LiveTest_GetFirstSignatureForAddress(t) @@ -38,14 +39,6 @@ func LiveTest_GetTransactionWithVersion(t *testing.T) { require.NoError(t, err) require.NotNil(t, txResult) }) - - // there's no such use case as of now because maxTxVersion is hard-coded in the zetaclient - //t.Run("should skip the transaction if the version is not supported", func(t *testing.T) { - // ctx := context.Background() - // txResult, err := rpc.GetTransaction(ctx, client, txSig) - // require.ErrorIs(t, err, rpc.ErrUnsupportedTxVersion) - // require.Nil(t, txResult) - //}) } func LiveTest_GetFirstSignatureForAddress(t *testing.T) {