From 1302dccb44b55ea0caf2fd3b1305dc5ff6f4f0d3 Mon Sep 17 00:00:00 2001 From: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Date: Thu, 23 May 2024 11:57:26 -0500 Subject: [PATCH] fix: don't skip unsupported chain param and let it update the `IsSupported` flag in context (#2233) * don't skip unsupported chain param and let it update the flag in zetacore context * added changelog entry --- changelog.md | 1 + zetaclient/zetacore/client.go | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/changelog.md b/changelog.md index ffb96c3be9..095b9ec6e4 100644 --- a/changelog.md +++ b/changelog.md @@ -42,6 +42,7 @@ * [1484](https://github.com/zeta-chain/node/issues/1484) - replaced hard-coded `MaxLookaheadNonce` with a default lookback factor * [2125](https://github.com/zeta-chain/node/pull/2125) - fix develop upgrade test * [2222](https://github.com/zeta-chain/node/pull/2222) - removed `maxHeightDiff` to let observer scan from Bitcoin height where it left off +* [2233](https://github.com/zeta-chain/node/pull/2233) - fix `IsSupported` flag not properly updated in zetaclient's context ### CI diff --git a/zetaclient/zetacore/client.go b/zetaclient/zetacore/client.go index 84ea0194d7..d64fd56db1 100644 --- a/zetaclient/zetacore/client.go +++ b/zetaclient/zetacore/client.go @@ -224,10 +224,6 @@ func (c *Client) UpdateZetacoreContext( // check and update chain params for each chain for _, chainParam := range chainParams { - if !chainParam.GetIsSupported() { - sampledLogger.Info().Msgf("Chain %d is not supported yet", chainParam.ChainId) - continue - } err := observertypes.ValidateChainParams(chainParam) if err != nil { sampledLogger.Warn().Err(err).Msgf("Invalid chain params for chain %d", chainParam.ChainId)