From d9cd55fef5a1fff0c271317911b7981936313ec5 Mon Sep 17 00:00:00 2001 From: skosito Date: Thu, 28 Mar 2024 13:06:17 +0100 Subject: [PATCH] PR comments --- x/emissions/keeper/block_rewards_components_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/x/emissions/keeper/block_rewards_components_test.go b/x/emissions/keeper/block_rewards_components_test.go index e2a0ad9d68..a203757a4f 100644 --- a/x/emissions/keeper/block_rewards_components_test.go +++ b/x/emissions/keeper/block_rewards_components_test.go @@ -68,9 +68,7 @@ func TestKeeper_GetFixedBlockRewards(t *testing.T) { k, _, _, _ := keepertest.EmissionsKeeper(t) fixedBlockRewards, err := k.GetFixedBlockRewards() require.NoError(t, err) - expected, err := emissionskeeper.CalculateFixedValidatorRewards(emissionstypes.AvgBlockTime) - require.NoError(t, err) - require.Equal(t, expected, fixedBlockRewards) + require.Equal(t, emissionstypes.BlockReward, fixedBlockRewards) } func TestKeeper_GetBlockRewardComponent(t *testing.T) { @@ -106,6 +104,7 @@ func TestKeeper_GetBlockRewardComponent(t *testing.T) { require.Equal(t, sdk.ZeroDec(), bondFactor) // non 0 value returned require.NotEqual(t, sdk.ZeroDec(), durationFactor) + require.Positive(t, durationFactor.BigInt().Int64()) }) }