From 9aae130872f5b02df50fdb0ae76e8dec79aa1f47 Mon Sep 17 00:00:00 2001 From: skosito Date: Mon, 1 Apr 2024 13:41:34 +0200 Subject: [PATCH] Remove redundant todos --- x/observer/types/parsers_test.go | 1 - x/observer/types/utils_test.go | 10 ++++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/x/observer/types/parsers_test.go b/x/observer/types/parsers_test.go index fefe78fdce..1c108fcee8 100644 --- a/x/observer/types/parsers_test.go +++ b/x/observer/types/parsers_test.go @@ -40,7 +40,6 @@ func TestParseStringToObservationType(t *testing.T) { {"TestValidObservationType1", "OutBoundTx", types.ObservationType(2)}, {"TestValidObservationType1", "TSSKeyGen", types.ObservationType(3)}, {"TestValidObservationType1", "TSSKeySign", types.ObservationType(4)}, - // TODO: this is wrong, ObservationType should check if value exists? {"TestInvalidObservationType", "InvalidType", types.ObservationType(0)}, } diff --git a/x/observer/types/utils_test.go b/x/observer/types/utils_test.go index 6a72dd4ab5..ac42ea127c 100644 --- a/x/observer/types/utils_test.go +++ b/x/observer/types/utils_test.go @@ -15,15 +15,13 @@ func TestConvertNodes(t *testing.T) { expected []*types.Node }{ { - name: "TestEmptyInput", - input: []blame.Node{}, - // TODO: is nil ok here, should be empty array? + name: "TestEmptyInput", + input: []blame.Node{}, expected: nil, }, { - name: "TestNilInput", - input: nil, - // TODO: is nil ok here, should be empty array? + name: "TestNilInput", + input: nil, expected: nil, }, {