From 5b9a2400b9fc1da2d3a5e91a4144ae3e9b0be4e8 Mon Sep 17 00:00:00 2001 From: Grant Zukel Date: Thu, 15 Feb 2024 13:45:05 -0700 Subject: [PATCH] adjusted the approver step --- .github/workflows/publish-release.yml | 4 ++-- changelog.md | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index c281e48fba..ef59cda4b2 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -417,11 +417,11 @@ jobs: - uses: trstringer/manual-approval@v1 with: secret: ${{ github.TOKEN }} - approvers: gzukel + approvers: kingpinXD,lumtis,brewmaster012 minimum-approvals: 1 issue-title: "Release Approval for version: ${{ github.event.inputs.version }}" issue-body: "Please approve the release. Once approved the release pipeline will continue." - exclude-workflow-initiator-as-approver: false + exclude-workflow-initiator-as-approver: true additional-approved-words: '' additional-denied-words: '' publish-release: diff --git a/changelog.md b/changelog.md index 0475f7c56f..49380473a7 100644 --- a/changelog.md +++ b/changelog.md @@ -41,6 +41,7 @@ ### CI +* Adjusted the release pipeline to be a manually executed pipeline with an approver step. The pipeline now executes all the required tests run before the approval step unless skipped. * Added pipeline to build and push docker images into dockerhub on release for ubuntu and macos. * Adjusted the pipeline for building and pushing docker images for MacOS to install and run docker. * Added docker-compose and make commands for launching full nodes. `make mainnet-zetarpc-node` `make mainnet-bitcoind-node`