Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: PHP 7.3 compatibility #21

Closed
wants to merge 3 commits into from
Closed

refactor: PHP 7.3 compatibility #21

wants to merge 3 commits into from

Conversation

pushpak1300
Copy link

@pushpak1300 pushpak1300 commented Apr 21, 2021 •
edited
Loading

For PHP 7.3 backward compatibility which resolves #19 .
Tested this on PHP7.3 locally and all tests are passing.

Screenshot from 2021-04-21 12-43-00

@vividvilla @ranjanrak

@ranjanrak
Copy link
Member

Thanks for the PR. I Will go through this over weekend and update here.

@pushpak1300
Copy link
Author

Thanks for the PR. I Will go through this over weekend and update here.

Any updates?

@ranjanrak
Copy link
Member

@pushpak1300
We should also remove the Mixed_ Docblock type enforced in invalidateRefreshToken and modifyOrder functions, when mixed type is already added in docblock comment above these functions.

@pushpak1300
Copy link
Author

@ranjanrak any updates?

@ranjanrak
Copy link
Member

LGTM. @vividvilla, you can merge this.

krish-damani
krish-damani reviewed Jul 26, 2021
View reviewed changes
src/KiteConnect.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish-damani krish-damani Awaiting requested review from krish-damani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with PHP 7.3
3 participants
@pushpak1300 @ranjanrak @krish-damani