Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: hci_uart_3wire: remove USB related code #82798

Conversation

jfischer-no
Copy link
Collaborator

There is no advantage to using the USB CDC ACM UART in this sample.
chery-picked from #80985

There is no advantage to using the USB CDC ACM UART in this sample.

Signed-off-by: Johann Fischer <[email protected]>
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hci_ samples are usually not really used as samples, but rather applications.

This PR removes a feature from one of these, and while the author claims that

There is no advantage to using the USB CDC ACM UART in this sample.

This may break things for anyone using that feature.

I don't think we really have any deprecation process for "samples", but perhaps we should at least mention this in the migration guide or release notes?

@cvinayak
Copy link
Contributor

The hci_ samples are usually not really used as samples, but rather applications.

This PR removes a feature from one of these, and while the author claims that

There is no advantage to using the USB CDC ACM UART in this sample.

This may break things for anyone using that feature.

I don't think we really have any deprecation process for "samples", but perhaps we should at least mention this in the migration guide or release notes?

The sample is originally a copy-paste of the hci_uart sample and its readme.rst file. USB use in 3-wire UART sample is redundant and outside the scope of the sample.

@kartben kartben merged commit 8f44b86 into zephyrproject-rtos:main Dec 12, 2024
27 checks passed
@jfischer-no jfischer-no deleted the pr-samples-hci_uart_3wire-remove-usb branch December 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants