boards: intel: ish: Improve Simics support #82657
Conversation
Improve Simics support for `boards/intel/ish/intel_ish_5_8_0` for better integration with the simulator. Signed-off-by: Dmitrii Golovanov <[email protected]>
zephyrbot
added
platform: Intel ISH
zephyrbot
requested review from
57300,
jeremybettis,
kwd-doodling,
nashif,
nordicjm,
teburd and
tejlmand
| --batch-mode | ||
| ${SIMICS_SCRIPT} | ||
| ${SIMICS_ARGS} | ||
| $ENV{SIMICS_EXTRA_ARGS} |
There was a problem hiding this comment.
Should we use EXTRA_SIMICS_ARGS to be aligned with other Zephyr CMake settings, like EXTRA_CONF_FILE, EXTRA_CFLAGS, etc. ?
Also, using zephyr_get(EXTRA_SIMICS_ARGS ...) will allow users to choose freely between sysbuild, CMake var -DEXTRA_SIMICS_ARGS=<val>, or environment variable and not force them into using env vars.
There was a problem hiding this comment.
SIMICS_EXTRA_ARGS got its name as one of many other SIMICS_* env variables which belong to Simics integration on the host level; its purpose - to pass through some custom platform parameters from user/CI to the simulator runtime through all the layers, so it is not in Zephyr naming domain.
Currently there is no need to ingest values there from other sources (CMake etc.) with zephyr_get(), but may be helpful to do that later (good idea, thanks @tejlmand).
Improve Simics support for
boards/intel/ish/intel_ish_5_8_0for better integration with the simulator.