Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: frdm_mcxc444: Add usb support #80805

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

NeilChen93
Copy link
Collaborator

Support usb for NXP frdm_mcxc444 board

@danieldegrasse
Copy link
Collaborator

Please take a look at the CI error

danieldegrasse
danieldegrasse previously approved these changes Nov 6, 2024
@danieldegrasse danieldegrasse added this to the v4.1.0 milestone Nov 6, 2024
dleach02
dleach02 previously approved these changes Nov 7, 2024
tmon-nordic
tmon-nordic previously approved these changes Nov 8, 2024
jfischer-no
jfischer-no previously approved these changes Nov 12, 2024
kartben
kartben previously approved these changes Nov 17, 2024
@danieldegrasse
Copy link
Collaborator

@NeilChen93 PR needs rebase to clear conflicts

@mmahadevan108
Copy link
Collaborator

@NeilChen93 , kindly fix merge conflicts. Also please add information on how this was tested.

@mmahadevan108
Copy link
Collaborator

@NeilChen93, please update the 4.1 release notes to indicate this support was added.

@kartben
Copy link
Collaborator

kartben commented Nov 22, 2024

@NeilChen93 ping?

@NeilChen93 NeilChen93 force-pushed the add_mcxc444_usb_support branch from 29d10cf to 11f6a15 Compare November 28, 2024 07:43
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 28, 2024
@danieldegrasse
Copy link
Collaborator

@NeilChen93 thanks for rebasing- there is unfortunately another merge conflict :/, it needs another rebase

@NeilChen93 NeilChen93 force-pushed the add_mcxc444_usb_support branch from 11f6a15 to 1313384 Compare December 3, 2024 07:20
danieldegrasse
danieldegrasse previously approved these changes Dec 3, 2024
@dleach02 dleach02 force-pushed the add_mcxc444_usb_support branch 2 times, most recently from b81fd52 to 0fdc7a3 Compare December 4, 2024 18:41
dleach02
dleach02 previously approved these changes Dec 4, 2024
danieldegrasse
danieldegrasse previously approved these changes Dec 4, 2024
@henrikbrixandersen
Copy link
Member

Please rebase on main and resolve any merge conflicts.

@@ -101,6 +101,7 @@ Boards & SoC Support

* All HWMv1 board name aliases which were added as deprecated in v3.7 are now removed
(:github:`82247`).
* Enabled USB on NXP ``frdm_mcxc444``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change as the whole release notes for 4.1 is under discussion about needs to be included.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the end of the world if it stays though, well simply clean things up when implementing the new release notes format

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase is required on this PR. So might as well remove it.

Support usb for NXP frdm_mcxc444 board.
Test it using samples/subsys/usb/console.

Signed-off-by: Neil Chen <[email protected]>
frdm_mcxc444 does not support MCUboot. Exclude the platform from dfu
sample.

Signed-off-by: Neil Chen <[email protected]>
Remove USB, RTC enable note for NXP frdm_mcxn236

Signed-off-by: Neil Chen <[email protected]>
@NeilChen93 NeilChen93 dismissed stale reviews from danieldegrasse and dleach02 via b2e115e December 8, 2024 09:15
@NeilChen93 NeilChen93 force-pushed the add_mcxc444_usb_support branch from 0fdc7a3 to b2e115e Compare December 8, 2024 09:15
@kartben kartben merged commit 3703506 into zephyrproject-rtos:main Dec 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards area: Samples Samples area: USB Universal Serial Bus platform: NXP NXP Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants