Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Refactor of Zend\Db\Metadata for 3.0.0 #365

Open
ezimuel opened this issue Mar 12, 2019 · 2 comments
Open

Refactor of Zend\Db\Metadata for 3.0.0 #365

ezimuel opened this issue Mar 12, 2019 · 2 comments

Comments

@ezimuel
Copy link
Contributor

ezimuel commented Mar 12, 2019

This is a task for refactoring Zend\Db\Metadata using the type hints of PHP 7.2. You must work on the 3.0.0 branch.

If you change the API you should report it in the /3.0.0.md file.

Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.

@arueckauer
Copy link
Contributor

@ezimuel I have a general question on what the best way it is to handle upcoming questions and issues. While refactoring I had a few questions and mentioned them in the PR comment.

Is this fine or would you prefer a discussion elsewhere, a separate issue, or ...?

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#16.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants