Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blade: Update to bf40d4f to fix crash #17319

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

apricotbucket28
Copy link
Contributor

@apricotbucket28 apricotbucket28 commented Sep 3, 2024

See #17005

This PR updates Blade to fix a regression from d1dceef, and also properly destroys all Vulkan objects (verified by enabling Vulkan validation in the source code, in both Wayland and X11).

Release Notes:

  • Linux: Fixed crash when closing windows on Wayland.

NOTE: This is 0.151.x only because 0.152.x contains an unrelated blade bump; we need to merge both into 0.152.x and 0.153.x

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 3, 2024
@ConradIrwin
Copy link
Member

@apricotbucket28 Thanks!

@ConradIrwin ConradIrwin merged commit 16ee4e6 into zed-industries:v0.151.x Sep 5, 2024
8 checks passed
@notpeter
Copy link
Member

notpeter commented Sep 6, 2024

FYI: This went out with Zed Stable v0.151.2 a few minutes ago.

jvmncs pushed a commit that referenced this pull request Sep 6, 2024
Closes #17005

Like #17319, but based on
kvark/blade#144.

This should be cherry-picked into preview if possible 🙂 

Release Notes:

- Linux: Fixed crash when closing windows on Wayland.
notpeter pushed a commit that referenced this pull request Sep 6, 2024
Closes #17005

Like #17319, but based on
kvark/blade#144.

This should be cherry-picked into preview if possible 🙂 

Release Notes:

- Linux: Fixed crash when closing windows on Wayland.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants