Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for numpy<2? #184

Closed
maresb opened this issue Jul 12, 2024 · 4 comments
Closed

Support for numpy<2? #184

maresb opened this issue Jul 12, 2024 · 4 comments

Comments

@maresb
Copy link
Contributor

maresb commented Jul 12, 2024

I'm really excited about this project, but it's currently pretty difficult to install in any non-minimal environment because Numpy 2.0 is so recent. How essential is your use of 2.0 features? Is there any chance of this being relaxed?

@TomNicholas
Copy link
Member

TomNicholas commented Jul 12, 2024

Hey! We're using numpy 2.0 for the new variable-length string dtype, as a good way to efficiently store arrays of paths to files.

Context here:

#33

#107 (comment)

If you really want backwards-compatibility and you want to make a contribution we can accept a PR that generalizes this, but its always going to be less efficient to use a fixed-length string dtype.

@maresb
Copy link
Contributor Author

maresb commented Jul 13, 2024

Thanks a lot for the explanation! Relying on a new dtype seems like fairly essential use of 2.0, and it'd probably be a significant amount of work to maintain a parallel backwards-compatible implementation.

I tracked down one of my current bottlenecks which is xaggpytablesnumpy<2, and happily that's being actively worked on 🚀!

I think my current strategy will be to build a separate container for the kerchunking step of my pipeline so that I can make use of VirtualiZarr until numpy 2 is widely supported.

Thanks so much for the quick response, it's really helpful!

@maresb maresb closed this as completed Jul 13, 2024
@TomNicholas
Copy link
Member

Sounds good! Let us know how you get on using VirtualiZarr.

@maresb
Copy link
Contributor Author

maresb commented Aug 17, 2024

With the PyTables release just now, there are no more dependency constraints blocking me from upgrading to NumPy 2 and using VirtualiZarr in my main environment. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants