scripts: Use workPanels font in output panel #4886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CHANGELOG > Add change note. - ConsolePanel > Don't set font. - OutputPanel > Use workPanels font. Signed-off-by: kingthorin <[email protected]>
thc202
reviewed
Sep 15, 2023
| @@ -216,7 +215,6 @@ private javax.swing.JToolBar getPanelToolbar() { | |||
| panelToolbar.setFloatable(false); | |||
| panelToolbar.setRollover(true); | |||
| panelToolbar.setPreferredSize(new java.awt.Dimension(800, 30)); | |||
| panelToolbar.setFont(FontUtils.getFont("Dialog")); | |||
There was a problem hiding this comment.
If we are removing here we should remove from scroll pane as well.
|
I don't mind this change but this is again another place I think we should have a specific font, having monospaced font by default would make it easier to read the output. |
|
Okay I don't mind closing this. I was going for something quick in light of my original understanding of the issue. I think you're right that having more specific options is probably better. We should pick-up the discussion in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
Related to zaproxy/zaproxy#8065
Checklist
./gradlew spotlessApplyfor code formatting