Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide core ValueGenerator through commonlib #4850

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Aug 28, 2023

Change commonlib add-on to provide the ValueGenerator, both the default implementation and the one provided by formhandler add-on.
Change graphql, openapi, soap, and spider to obtain the value generator from the commonlib and also depend on its extension (if not already).

Part of zaproxy/zaproxy#8016.

Change `commonlib` add-on to provide the `ValueGenerator`, both the
default implementation and the one provided by `formhandler` add-on.
Change `graphql`, `openapi`, `soap`, and `spider` to obtain the value
generator from the `commonlib` and also depend on its extension (if not
already).

Part of zaproxy/zaproxy#8016.

Signed-off-by: thc202 <[email protected]>
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks!!!

Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ricekot ricekot merged commit 7ae219f into zaproxy:main Aug 29, 2023
10 checks passed
@thc202 thc202 deleted the commonlib/value-generator branch August 29, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants