Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove or document reload zshrc key binding #15

Open
russell-holgate opened this issue Sep 22, 2023 · 1 comment · Fixed by #16
Open

remove or document reload zshrc key binding #15

russell-holgate opened this issue Sep 22, 2023 · 1 comment · Fixed by #16
Assignees
@mamaraddio

Comments

@russell-holgate
Copy link

Currently supercharge has a binding to reload .zshrc:
bindkey -s '^x' '^usource ${ZDOTDIR:-$HOME}/.zshrc\n'
I think this either needs to be documented in README.md and/or provide user feedback with an echo 'reloading zshrc...', or removed.

The reason I think it may be better to remove it is the potential for user errors:

  • accidental ctrl-z or ctrl-c presses due to proximity
  • expectation of a fresh shell (i.e. exec zsh)
@zap-zsh zap-zsh locked and limited conversation to collaborators Sep 22, 2023
@zap-zsh zap-zsh unlocked this conversation Sep 22, 2023
@mamaraddio
Copy link
Member

mamaraddio commented Sep 22, 2023 •
edited
Loading

Personally I think this is a feature not something to be removed.

I'll add a few lines to document this on the README.md file because yeah it's always a good idea to document things.

In the meanwhile what do @ChristianChiarulli think about that?

Also community could express it's thought adding emojis to this comment.
👍 to keep the functionality
👎 to remove it

mamaraddio added a commit that referenced this issue Sep 23, 2023
@mamaraddio
Ask community though to #15
09d046f
@mamaraddio mamaraddio mentioned this issue Sep 23, 2023
Merged
mamaraddio added a commit that referenced this issue Sep 23, 2023
@mamaraddio
Document CTRL+X binding (#16)
c917cf0 
* Document CTRL+X feature

* fix line n in sed

* Use $ZSHRC variable exported by Zap

* Ask community though to #15

* fix issue link
@mamaraddio mamaraddio self-assigned this Sep 23, 2023
@mamaraddio mamaraddio linked a pull request Sep 23, 2023 that will close this issue
Document CTRL+X binding #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mamaraddio mamaraddio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document CTRL+X binding zap-zsh/supercharge
2 participants
@mamaraddio @russell-holgate