Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify and resolve random performance bottlenecks #23

Open
JustinSainton opened this issue Nov 11, 2019 · 1 comment
Open

Identify and resolve random performance bottlenecks #23

JustinSainton opened this issue Nov 11, 2019 · 1 comment

Comments

@JustinSainton
Copy link
Member

JustinSainton commented Nov 11, 2019 •
edited
Loading

noticed that
removeInvalidFavorites called from getFavoritesArray is heavy load on page with lot of favaorites.

https://user-images.githubusercontent.com/9116220/54296432-9c01a600-45bd-11e9-8472-9bd08a2a4fdf.png

Also, get_user_favorites() and get_user_favorites_count() called both on page lead to double query requests.
@JustinSainton
Copy link
Member Author

JustinSainton commented Nov 19, 2019 •
edited
Loading

Also, current semi-updated codebase has some noted performance issues.

Check performance on the Promise objects being returned when getting Favorites. It's a bit laggy. Console logging shows Add/Remove iterating through a few times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustinSainton