Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout on the network requests #9

Open
rkhwaja opened this issue Dec 14, 2017 · 1 comment
Open

Add a timeout on the network requests #9

rkhwaja opened this issue Dec 14, 2017 · 1 comment

Comments

@rkhwaja
Copy link

rkhwaja commented Dec 14, 2017

See http://docs.python-requests.org/en/master/user/advanced/#timeouts
I'd suggest 3-10 seconds

@rkhwaja
Copy link
Author

rkhwaja commented Dec 16, 2017

I think that we can do this with the passed in session in the current outstanding pull request. We override the get method on the session object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant