Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another problem with maxfontsize - and minfontsize #65

Open
stacef opened this issue Nov 25, 2014 · 3 comments
Open

Another problem with maxfontsize - and minfontsize #65

stacef opened this issue Nov 25, 2014 · 3 comments
Labels

Comments

@stacef
Copy link

stacef commented Nov 25, 2014

Hey there,

I'm having a problem using the the max and min font size settings: that is, when I set those options, every span is set to either the max or the min font size and nothing in between. If I don't set those options, font sizes are variable and set appropriately and as expected (though too big for my needs). This replicates with default and custom fonts and regardless of when BigText is called.

It appears the issue is with this bit of code:

    if(newFontSize + j*intervals[m] > maxFontSize) {
        newFontSize = maxFontSize;
        break outer;
    }

This same code seems to be problematic in this issue as well - #62 - and, similarly, commenting out these lines resolves my issue.

Thoughts on a better solution or why this behavior is occuring are welcome!

Thanks

@zachleat
Copy link
Owner

Can you link to a test case? Or create one on jsbin/jsfiddle? Thanks!

@devonmather
Copy link

I've had the same issue, using Bigtext with no parameters set the plugin works fine, however when those parameters are set the plugin shows min or max font size and nothing in between.

I need the parameters to work othersie the text blows out in size in some cases and looks bad.

Thanks in advance!

@Copperdust
Copy link

Using v0.1.8 I get the same problem - Text always shows up outside its container, unless it is too big, and on resize it will resize assuming the text's width is the one of its container, which is overflowing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants