Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Make attributes property virtual #88

Open
LightAndrek opened this issue May 24, 2021 · 0 comments
Open

[Request] Make attributes property virtual #88

LightAndrek opened this issue May 24, 2021 · 0 comments

Comments

@LightAndrek
Copy link

I am developing a localized website and I need the breadcrumbs to be localizable too.
Usually when I write a localizable attribute I create a constructor with the type of Resources and a string that would be the key to search for. This is the same concept used, for example, by the DisplayAttribute in the COmponentModel namespace.

public class BreadcrumbAttribute(string titleKey, Type resourceType)

I tried to replicate the same operation by deriving a class from the BreadcrumbAttribute attribute but since the proprties are not virtual it is not possible for me to change the behavior in the correct way.

Suggestion

Make all properties in the BreadcrumbAttribute as virtual
OR
Implements the localization pattern directly inside the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant