Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Python 3.12 #183

Closed
temminks opened this issue Nov 13, 2024 · 1 comment
Closed

Support for Python 3.12 #183

temminks opened this issue Nov 13, 2024 · 1 comment
Assignees
@z3z1ma
Labels
good first issue Good for newcomers

Comments

@temminks
Copy link

Can we update the pyprojekt.toml file so that dbt-osmosis would run with Python 3.12? I tried setting the allowed python versions to "...<3.13" and was able to poetry install the project.

Are there other requirements that need to be considered before updating?
@z3z1ma z3z1ma self-assigned this Nov 15, 2024
@z3z1ma z3z1ma added the good first issue Good for newcomers label Nov 15, 2024
@temminks
Copy link
Author

I think the current design of the test pipeline won't work with the update of the python versions:
You are currently installing dbt-core using poetry add which will evaluate the python-versions defined in tool.poetry.dependencies. This is already failing for your current test-matrix for dbt-core 1.6.0 and 1.7.0 (eg, https://github.com/z3z1ma/dbt-osmosis/actions/runs/11859711262/job/33053298311). Only since dbt-core >= 1.7.9 supports python 3.12.

I think a more realistic testing scenario would be to install dbt-core 1.6.0 first and then install dbt-osmosis as a package to be used with that version.

I started a branch here that I'll have to clean up: https://github.com/temminks/dbt-osmosis

@syou6162 syou6162 mentioned this issue Dec 29, 2024
Closed
@z3z1ma z3z1ma closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@z3z1ma z3z1ma

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support python 3.12 syou6162/dbt-osmosis
2 participants
@temminks @z3z1ma