Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Skip updating column descriptions #179

Closed
brandonpeebles opened this issue Sep 24, 2024 · 1 comment
Closed

[feature request] Skip updating column descriptions #179

brandonpeebles opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@brandonpeebles
Copy link

Feature:

Ability to skip updating column descriptions or the ability to specify what keys from the YAML you want to force inheritance for (e.g. progenitor, description, tags, etc.).

Use case:

Currently if I want to update certain column info like progenitor, I have to use --force-inheritance. This is normally fine, but sometimes there are cases where we add extra detail to a description in one model that isn't needed for that same column upstream.

The issue arises when we might change the source of one model perhaps for a cutover (e.g. ref('my_model')ref('my_model_v2') and then I want to update the osmosis_progenitor metadata. If I run dbt-osmosis refactor it won't update the value since there's already something there. But if I force inheritance, I'll also overwrite any custom descriptions I might've added.

@z3z1ma z3z1ma self-assigned this Nov 15, 2024
@z3z1ma z3z1ma added the enhancement New feature or request label Nov 15, 2024
@z3z1ma
Copy link
Owner

z3z1ma commented Jan 2, 2025

This will now be the default behavior. Not overriding if a description exists. It was the original intention really.
Once #189 is merged. We might tag a 1.0.0 release with it.

@z3z1ma z3z1ma closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants