Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Jun 19, 2019

  1. Fix the bug which prevents suggesting words

    The code intended to show the user 'Potential Matches' when the entry
    is not found on Webster's dictionary. The feature is valuable since it
    guides the user to the nearest valid words. Still, there is a
    mistake in the condition that prevents it to be met at the right
    moments. Fix the condition to let the add-on notify users of the
    suggested words.
    shahrokh-bahtooei committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    24a08d7 View commit details
    Browse the repository at this point in the history
  2. Refactor get_preferred_valid_entries() according to DRY

    DRY rule says, "Don't repeat yourself." The code will be easier to
    read if we develop every logic once and then reuse it.
    shahrokh-bahtooei committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    6afe296 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Add pronunciation and phonetic transcription for undefined words

    There are many words in Merriam Webster’s dictionary that derive from
    other words but do not include a definition. Webster calls these
    words Undefined Run-Ons (UROs). Despite lack of definition, it has
    specified part-of-speech for all, and stated pronunciation and
    phonetic transcription for considerable numbers of them.
    
    To cover also adding pronunciation and phonetic transcription of
    undefined words, we should look for them at URO (Undefined Run-On)
    tag of the related entries. This requires us to include potential
    entries in our search criteria in due time and expand procedures of
    adding vocal pronunciation and phonetic transcription.
    
    To reduce complexity, clean coders prefer modular structure. Refactor
    _get_definition() while keeping the solution approach as same as
    possible.
    
    Resolves: z1lc#27
    shahrokh-bahtooei committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    54c0fc1 View commit details
    Browse the repository at this point in the history