Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the unused parameters in Adapointr #129

Open
pkqbajng opened this issue Sep 20, 2023 · 2 comments
Open

Question about the unused parameters in Adapointr #129

pkqbajng opened this issue Sep 20, 2023 · 2 comments

Comments

@pkqbajng
Copy link

Hi, sir, thanks for your excellent job. However, I found that the parameters of the query ranking won't be updated during the training procedure if set find_unused_paramters=False. Could you please check its effectiveness?

@yuxumin
Copy link
Owner

yuxumin commented Sep 20, 2023

Yes, it wont be optimized. The right implementation of this ranking is based on gumble-softmax, we will correct the code for this part in next push.

@pkqbajng
Copy link
Author

Okay, thanks for your reply. When conducting ablation study on this, does you concat the generated query with the input ones and then use farthest sampling in the original experiments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants