Add a docker image loader TOSCA component #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AUTO_REMOVE: { get_property: [SELF, auto_remove] } | ||
| CLEANUP: { get_property: [SELF, cleanup] } | ||
| COMMAND: { get_property: [SELF, docker_run_cmd] } |
There was a problem hiding this comment.
We should probably also deal with docker_run_args.
Note that the docker_container ansible module accept also a list of strings as a command...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
Added new TOSCA component to be able to load a docker image from a tar archive, as described in GH-140
Misc.: fixed some installation issues
What I did
org/ystia/docker/images/types.yml:Added a TOSCA compoent type
org.ystia.docker.images.ArchiveLoaderto load a docker image from a tar archiveAdded as well a TOSCA component type
org.ystia.docker.images.RuntimePathArchiveLoaderto load a docker image from a tar archive whose path is only known at runtime.org/ystia/docker/images/playbooks/create.yamlorg/ystia/docker/images/playbooks/load_archive.yamlorg/ystia/docker/images/playbooks/remove_image.yamlAdded implementations for these component interfaces
Misc - Fixed some installations issues:
org/ystia/docker/ansible/playbooks/create.yamlUpdated the repository url to support different versions
org/ystia/docker/containers/generic/playbooks/create.yamlFixed some pip installation issues
org/ystia/docker/containers/generic/playbooks/delete.yamlorg/ystia/docker/containers/generic/playbooks/start.yamlorg/ystia/docker/containers/generic/playbooks/stop.yamlFixed an issue where the fact that the container id can change at startup was not taken into account
org/ystia/experimental/consul/linux/ansible/playbooks/consul_install.yamlFixed a pip installation issue
How to verify it
Tested in LEXIS project, where a tar gz is stored in a Distributed Data Infrastructure.
This tar gz is downloaded from the Distributed Infrastructure on a Compute Instance, the path on the compute instance being computed at runtime.
A TOSCA component of type
org.ystia.docker.images.RuntimePathArchiveLoaderis then used to load the docker image from this tar gz.See corresponding topology template and component instantiation at https://github.com/lexis-project/application-templates/blob/v0.1.3/weather-climate/applications/adms/adms_template.yaml#L585-L600
Description for the changelog
Add a TOSCA component to load a docker image from a tar archive (GH-140)
Applicable Issues
Fixes #140