Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Error Gnome 3.38 #58

Open
rebdeg opened this issue Sep 13, 2020 · 21 comments
Open

Error Gnome 3.38 #58

rebdeg opened this issue Sep 13, 2020 · 21 comments

Comments

@rebdeg
Copy link

rebdeg commented Sep 13, 2020

Can't install this extension under gnome 3.37.92 (3.38), gives an error.

@dayfuaim
Copy link

I confirm this.

It's "No JS module 'tweener' found in search path", to be more precise.

@yozoon
Copy link
Owner

yozoon commented Sep 22, 2020

Thanks for reporting this bug - I will look into it as soon as I have a GNOME 3.38 installation available for testing.

@yozoon yozoon added the bug label Sep 22, 2020
@xerz-one
Copy link

Have you debugged the issue? GNOME OS is available if your distro is still stuck on 3.36

@ghost
Copy link

ghost commented Oct 9, 2020

There's also Ubuntu 20.10 beta and Fedora 33 beta I believe, dying for this to be fixed, the same error has broke a few extensions I use actually

@MichalLebeda
Copy link

Have you debugged the issue? GNOME OS is available if your distro is still stuck on 3.36

It is evident that Tweener has been removed see link

@yozoon
Copy link
Owner

yozoon commented Oct 9, 2020

I'm on Arch, which already updated GNOME to version 3.38. Yes the removal of Tweener is one problem, but the second complication is that GNOME also changed the way background content is represented in the MetaBackground actor... fixing this without causing problems for older versions will take some time

@aeveris
Copy link

aeveris commented Oct 9, 2020

Tweener is still available, but its import path has changed to imports.tweener.tweener

@MichalLebeda
Copy link

I'm on Arch, which already updated GNOME to version 3.38. Yes the removal of Tweener is one problem, but the second complication is that GNOME also changed the way background content is represented in the MetaBackground actor... fixing this without causing problems for older versions will take some time

tried to fix that in my pull req, but i thought that versioning is managed by extensions gnome webpage. So you can ignore it as it doesn't handle shell versions (my fault)

@MichalLebeda
Copy link

Can't we just use older version for 3.36 and newer fixed version for 3.38+?

@ghost
Copy link

ghost commented Oct 13, 2020

I'm just a user who reports bugs I find but I'd personally be fine with the above ^ assuming the devs would want to do it.
Maybe a branch for the people willing to test and help out or something?

@MichalLebeda
Copy link

I'm just a user who reports bugs I find but I'd personally be fine with the above ^ assuming the devs would want to do it.
Maybe a branch for the people willing to test and help out or something?

my fork works on 3.38 and it was easy to fix. The problem is, that it blinks with blackscreen when closing overview now, IDK why + no backward compatibility

@yozoon
Copy link
Owner

yozoon commented Oct 14, 2020

You can now test the extension on branch 338. It generally works now by checking the shell version and doing the appropriate action for that version (way to many if statements for my taste...). But sometimes I still get some some weird runtime behaviour like panel blur appearing and disappearing spontaneousely. For some reason the panel background opacity gets blurred sometimes as well, leading to a washed out blur effect...
Maybe someone can pin down the exact cause of those problems. I haven't yet been able to find anything in the logs that could point me towards a solution.

@ghost
Copy link

ghost commented Oct 14, 2020

I'll get to testing and let you know if I find anything reliable or useful, as always big thanks yozoon!

@ghost
Copy link

ghost commented Oct 14, 2020

Edit: It's running pretty well on my end, haven't seen any panel weirdness yet but I have found three issues, where's the best place to report the issue?

@Alexmitter
Copy link

Alexmitter commented Oct 16, 2020

Isn't tweener now just imports.tweener.tweener; instead of imports.ui.tweener; ?

Like Panel OSD extension does https://gitlab.com/jenslody/gnome-shell-extension-panel-osd/-/merge_requests/30/diffs

@yozoon yozoon added this to the GNOME 3.38 Support milestone Oct 18, 2020
@maxjf1
Copy link

maxjf1 commented Oct 26, 2020

Its possible to use something like this to keep it compatible?

const Tweener = imports.tweener ? imports.tweener.tweener :  imports.ui.tweener;

@Hexcz
Copy link

Hexcz commented Nov 3, 2020

Changed Tweener const as seen on @Alexmitter post, and installed clutter, didnt worked...

@Hexcz
Copy link

Hexcz commented Nov 30, 2020

You can now test the extension on branch 338. It generally works now by checking the shell version and doing the appropriate action for that version (way to many if statements for my taste...). But sometimes I still get some some weird runtime behaviour like panel blur appearing and disappearing spontaneousely. For some reason the panel background opacity gets blurred sometimes as well, leading to a washed out blur effect...
Maybe someone can pin down the exact cause of those problems. I haven't yet been able to find anything in the logs that could point me towards a solution.

Apparently the changes on this branch worked for me. No issues found so far. Thanks!

@henrik-wittenberg
Copy link

Does not work for me on manjaro gnome 3.38.2 (lg shows "No JS module 'tweener' found in search path").

@Hexcz
Copy link

Hexcz commented Dec 4, 2020

Does not work for me on manjaro gnome 3.38.2 (lg shows "No JS module 'tweener' found in search path").

Try using the 338 branch instead of master. It should work.

@ghost
Copy link

ghost commented Dec 6, 2020

I just wanted to come back and say, I've been using the 338 branch since just before Ubuntu 20.10 released in hopes of being useful and reporting bugs but besides the one already reported about the folders in dash, I haven't run into any. It's working smoothly for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

10 participants