Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming scope to prevent deprecation warning #20

Open
adrianjost opened this issue Feb 8, 2020 · 0 comments · May be fixed by #21
Open

Consider renaming scope to prevent deprecation warning #20

adrianjost opened this issue Feb 8, 2020 · 0 comments · May be fixed by #21

Comments

@adrianjost
Copy link

I think this package has a naming conflict with the ejs prop scope which results in the depreaction warning.

scope option is deprecated and will be removed in EJS 3

Renaming the variable scope to something similar like scopeString in the folloing two files should solve the issue.
@adrianjost adrianjost linked a pull request Feb 8, 2020 that will close this issue
Open
adrianjost added a commit to adrianjost/oauth2-firebase that referenced this issue May 22, 2021
@adrianjost
Merge pull request #5 from adrianjost/bugfix/yoichiro#20-ejs-deprecat…
2c70942 
…ion-warning

remove EJS deprecation warning by renaming variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove EJS deprecation warning by renaming variable adrianjost/oauth2-firebase
1 participant
@adrianjost