-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Their lights" #22095
base: master
Are you sure you want to change the base?
"Their lights" #22095
Conversation
or show up when you clownmag |
good technical quality, i just think they look too complex compared to other stuff here - they stick out. |
They should match our newer wall mounts - like cameras - better than what we use now |
Sprites look good. Adds another incentive to get those walls re-sprited :^) |
this has been bugging me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lights will be reviewed once the wall re sprites are more close to being completed
Very nice! The old wall lights have felt a bit broken honestly ever since that bug with the color happened a few years ago. I am glad to see they're getting a once-over. Great work! With lighting being more important now that departments have the option to start in a "lights out" state, a bit of polish is nice. |
Document the changes in your pull request
Hello hi. This PR resprites all of our lights and light tubes and variants of those things. Bonus stuff includes:
icons/obj/lighting.dmi
to better please your brains pattern recognition bitsA solid 90% of the work here is thanks to:
Paxilmaniac for initially respriting lights in tgstation/tgstation#77229
Onule for editing the lights to look much better in tgstation/tgstation#77594
RedBaronFlyer for adding inhands and editing light tube box overlays to match in tgstation/tgstation#79755
L0pz for respriting the light replacer tool in tgstation/tgstation#83546 so I could steal it in the friendliest way possible before they merge it themselves, tweak the sprite to look even nicer, and include it in this PR
Behold da lights
Why is this good for the game?
Simple answer? They look good.
Simpleish answer?
These are one of the few things from /TG/ I like a lot, they strike a good stylistic balance between simple and complicated., something we're in sore need of.
Testing
Spriting
Most sprites greatly modified by myself (like the overlays for example)
BEFORE
AFTER
Malf AI ability updates:
-->
-->
(repathed floor_emergency to avoid duplicate icons)
-->
this one I'm proud of since it's animated like this
Wiki Documentation
Ye I'll do that
Changelog
🆑 AMyriad, Paxilmaniac, Onule, RedBaronFlyer, L0pz
imageadd: Light bulbs, light tubes, floodlights, and light fixtures of all varieties have been visually overhauled
imageadd: Light tubes will now show up in your hands when held
imageadd: Resprited the light replacer tool
imageadd: Floor lights should now also turn purple if a revenant uses their shock ability
imageadd: Resprited malf AI's ability buttons for "blackout", "emergency lights", and "reactivate cameras"
/:cl: