Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment submission #3

Open
yogin opened this issue Feb 3, 2014 · 2 comments
Open

Assignment submission #3

yogin opened this issue Feb 3, 2014 · 2 comments

Comments

@yogin
Copy link
Owner

yogin commented Feb 3, 2014

/cc @nesquena @timothy1ee

Here's my submission for the Twitter app.
All feature stories are there.

There's definitely room for improvement, especially around the detail view constraints, but it's working :)

Note that I didn't use the reference project, and started from scratch.

@yogin
Copy link
Owner Author

yogin commented Feb 4, 2014

updated auto layout constraints for cells and detail view

@timothy1ee
Copy link
Collaborator

Good job! The point of this homework was to explore some challenges involved in developing a richer MVC client. Below is the checklist I went through when reviewing your application.

  • Did you create a custom Tweet cell and properly set up Auto Layout constraints?
  • Did you augment the User and Tweet model with the required properties?
  • Does tapping on a Tweet take you to a detailed Tweet view?
  • Is the detailed Tweet view styled like the mock?
  • Did you add both standard and retina (@2x) image assets? A new feature of XCode is to use the Images.xcassets, it makes it easier to handle the standard and retina assets. If you only included standard assets, it will be scaled for retina displays which makes them a little blurry.
  • Does tapping on retweet and favorite increment the retweet and favorite count? If I go back to the index and tap on the same tweet again, is the tweet still marked as retweeted or favorited with the correct count?
  • Does the compose view restrict the number of Twitter characters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants