Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline json fixtures #2

Open
2 tasks done
philnewm opened this issue Sep 3, 2024 · 0 comments
Open
2 tasks done

Streamline json fixtures #2

philnewm opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@philnewm
Copy link
Collaborator

philnewm commented Sep 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the enhancement you have in mind and explain what the current shortcomings are?

The currently defined pytest fixtures for github output - showing a json dictionary are rpetty redundant and hard to read
It might make sense to safe these as files and/or include data from a base template.

How would you imagine the implementation of the enhancement?

Either json files are able to include other json fiels or using yaml to merge multiple json files could be an efficient solution.
But the pytest should stay fast so it would be preferred to only use as much additional pyhton code as really neccessary.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

just having pure json files to be read by pytest fixtures.

Additional context:

No response

@philnewm philnewm added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant