Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement backward compatibility of some template keys for asset directory mapping #170

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Implement backward compatibility of some template keys for asset directory mapping #170

wants to merge 4 commits into from

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add backward compatibility of the template keys such as {product[type]} and {folder[type]} for asset directory mapping. If the keys are detected, the system would be using their replacements for mapping the directories.
Resolve #156

Additional review information

n/a

Testing notes:

  1. Launch Unreal
  2. Set some old template keys in ayon+settings://unreal/loaded_asset_dir or ayon+settings://unreal/loaded_layout_dir
    image
  3. Load Assets

@moonyuet moonyuet added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels Nov 26, 2024
@moonyuet moonyuet self-assigned this Nov 26, 2024
@antirotor
Copy link
Member

I would make those warnings more artist friendly - only TD can act on them (change the templates) but it would be artists that will see them first. Something like:

Deprecated settings: AYON is using settings that won't work in future releases. Details: {product[type]} in the template should be replaced with {product[productType]}.

What do you think?

@moonyuet
Copy link
Member Author

I would make those warnings more artist friendly - only TD can act on them (change the templates) but it would be artists that will see them first. Something like:

Deprecated settings: AYON is using settings that won't work in future releases. Details: {product[type]} in the template should be replaced with {product[productType]}.

What do you think?

I updated the debug message in 499d920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antirotor antirotor Awaiting requested review from antirotor

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

At least 1 approving review is required to merge this pull request.

Assignees

@moonyuet moonyuet

Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-6935_UE: Asset Directory for loaded asset do not support product type in template
2 participants
@moonyuet @antirotor