Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs build instruction #235

Closed
wants to merge 2 commits into from

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Update Docs instructions.
resolve #234

This PR was inspired by #223

Testing notes:

follow the building instructions in the PR and confirm it works.

@MustafaJafar MustafaJafar added the type: enhancement New feature or request label Sep 7, 2024
@MustafaJafar MustafaJafar self-assigned this Sep 7, 2024
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth - I preferred the old instructions. To the point, and simple command line stuff I could almost directly copy paste into my terminal. Now I need to search through a lot of text to see what I should do and copy each line individually.

I'd rather keep the old command line instruction - and maybe ONLY add this below it as 'explanation'.

- `yarn add docusaurus --dev`
- `cd {ayon-doc-repo}/website`
- `yarn start`
- Download and install Node.js from [nodejs.org](https://nodejs.org/en/download).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Download and install Node.js from [nodejs.org](https://nodejs.org/en/download).
- Download and install [Node.js](https://nodejs.org/en/download).

Would this suffice too?

Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you would want to explain each step but I think Roy is right.

Also these are developers that are using this repo, they should have a rough idea of what each command does and if not then they can look it up.

@MustafaJafar
Copy link
Contributor Author

Thank you for your feedback.
Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User friendly docs build instructions
3 participants