Load and manage products from a library project

[moonyuet]

Changelog Description

This PR is to support loading assets from the library project while the users can update and set versions with the containers from the loaded assets in the scene inventory tools. In the DCC hosts, you need to add the project_name as part of the container data, otherwise it will use the current project name instead(which results to the Entity N/A shown in the #983)
Resolve #983

Additional info

Make sure using the self.filepath_from_context(context) for the updating function in the loaders.

Testing notes:

1. Load Assets from the current project and library projects
2. Go to scene inventory to set version or update
3. Should be working.

[iLLiCiTiT]

I'm afraid you chose easy way, which does complicate things a lot.

Once we decide we want to work with different projects on containers, we have to work with that in UI and api too. I'll use one example get_version_items which did expect product ids, but now also expects representation ids, those representation ids are used to find corresponding container, to find corresponding project. That is by design bad, that method should expect project name and product ids, when you call it, you should have prepared mapping to which projects which product ids belong.

All places using that method have access to container items, so they also have access to correct project name. You should use that as advantage.

[BigRoy]

I think this is the wrong approach because we'd need to know which product id belongs to which project. What @iLLiCiTiT mentioined before is to separate the query to self._controller.get_version_items() to have separate calls per project. So above, we'd get the product ids per project and then here we would do:

version_items_by_product_id = self._controller.get_version_items(project_name, product_id)

As stated before - as far as I know on the backend nothing is keeping the database from having a product entity with the same id across different projects. Is that correct @martastain ? (It's unlikely by just creating products to happen, but when cloning e.g. projects I suppose it may very well share the same ids?) As such, we should still make sure to be explicit about which project each entry belongs to.

The same goes for version_items_by_product_id dict. That should technically also be "per project" because otherwise product_id may overlap accidentally.

@iLLiCiTiT thoughts?

[iLLiCiTiT]

Yes

[BigRoy]

Aside of their being plenty of code style notes I gave this a quick test run - and it seems to work fine.

Opening the scene inventory with containers from another project showed these entities just fine. However, visually there's NO clue whatsoever in the scene inventory that these are from another project.

I wonder whether it warrants somehow highlighting them. I was thinking of adding a project_name column to the Scene Inventory UI and potentially highlighting the name AYON blue using a delegate if the project name is not the current project.

But this is looking really nice.

I tested it with this PR: ynput/ayon-maya#176

[iLLiCiTiT]

It should be somewhat functional. Please re-test and report bugs.

QUESTION: What to do about switch dialog? Even I'm not able to make it work across projects, and it will be PITA to allow it for different than current project.

[moonyuet]

It should be somewhat functional. Please re-test and report bugs.

Works okay in my side.

QUESTION: What to do about switch dialog? Even I'm not able to make it work across projects, and it will be PITA to allow it for different than current project.

But we need to think about if there is any case of which same folder path and task name across different project....

[BigRoy]

Set Version does not work in scene inventory in Houdini on product from another project. Error:

Traceback (most recent call last):
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 392, i
n <lambda>
    lambda: self._show_version_dialog(item_ids, active_repre_id)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 821, i
n _show_version_dialog
    versions |= {
                ^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 822, i
n <setcomp>
    version_item.version
AttributeError: 'dict' object has no attribute 'version'

[moonyuet]

Set Version does not work in scene inventory in Houdini on product from another project. Error:

Traceback (most recent call last):
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 392, i
n <lambda>
    lambda: self._show_version_dialog(item_ids, active_repre_id)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 821, i
n _show_version_dialog
    versions |= {
                ^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 822, i
n <setcomp>
    version_item.version
AttributeError: 'dict' object has no attribute 'version'

I am testing with other hosts too(Maya, Zbrush and Unreal), it is generally not working when setting version....

[MustafaJafar]

Set Version does not work in scene inventory in Houdini on product from another project. Error:

Traceback (most recent call last):
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 392, i
n <lambda>
    lambda: self._show_version_dialog(item_ids, active_repre_id)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 821, i
n _show_version_dialog
    versions |= {
                ^
  File "F:\dev\ayon-core\client\ayon_core\tools\sceneinventory\view.py", line 822, i
n <setcomp>
    version_item.version
AttributeError: 'dict' object has no attribute 'version'

I was able to reproduce the same error.

[MustafaJafar]

Tested along ynput/ayon-houdini#185 and it works.

[BigRoy]

Works for me now (tested Houdini and Fusion).

Would be nice however if the "Project" was inherited upwards to the parent group, so you don't need to expand the entries to see the Project name.

[iLLiCiTiT]

What about switch dialog? Allow to show it only if items from one project are selected?

[BigRoy]

What about switch dialog? Allow to show it only if items from one project are selected?

I guess that'd be a first step yes. But honestly, I'd just add a Project field in there. If not changed by user, it acts as "do not change project", etc. just like the other fields. However, I imagine that's also quite a refactor - as such, we may want to leave that for separate PR.

[iLLiCiTiT]

I guess that'd be a first step yes. But honestly, I'd just add a Project field in there. If not changed by user, it acts as "do not change project", etc. just like the other fields. However, I imagine that's also quite a refactor - as such, we may want to leave that for separate PR.

Made it stupid and show the dialog per project (so if containers from 3 projects are selected it will show the dialog 3 times).