Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render review and thumbnail fail due to missing OCIO config #71

Open
1 task done
jrsndl opened this issue Nov 8, 2024 · 2 comments
Open
1 task done

Render review and thumbnail fail due to missing OCIO config #71

jrsndl opened this issue Nov 8, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@jrsndl
Copy link

jrsndl commented Nov 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Description

Current Behavior

With path to OCIO config set in core settings: ayon+settings://core/imageio/ocio_config_profiles for Blender host,
Using Cycles renderer with compositing enabled fails to make review and thumbnail on farm.

The OIIOtool expects valid path to OCIO.

Image

Steps To Reproduce:

  1. Configure OIIOtool to convert the exr to png sequence
  2. Publish exr render from Blender 4.2 to Deadline
  3. No review or thumbnail is created

Additional context:

Version

Server 1.42, ayon_core 1.06, ayon_blender 0.2.5

What platform were you running when you found the bug?

Windows

You can also provide any additional information relevant to the issue.

This change can be a quick fix:

  • It uses OCIO path from envinronment (might be an issue for multi-platform farms)
  • The hardcoded Display and View values are swapped and use more typical OCIO 1.0 names

Image

https://github.com/ynput/ayon-blender/blob/b9ea07ec0098a4ca00727e87a6b374f526a13e8e/client/ayon_blender/plugins/publish/collect_render.py#L110C13-L112C52

Relevant log output:

INFO:pyblish.ExtractThumbnail:oiiotool ERROR: -ociodisplay : DisplayViewTransform error. Cannot find source color space named 'Linear'.
2024-11-08 10:59:38:  0: STDOUT: Full command line was:
2024-11-08 10:59:38:  0: STDOUT: > oiiotool.exe --nosoftwareattrib --colorconfig  -i:ch=rgba.R,rgba.G,rgba.B,rgba.A //server/mount/projects/T037_Ayon_IOtest2/shots/blendertest01/work/lgt/renders/blender/blendertest01_lgt_v008/blendertest01_renderLgtMain_beauty.1013.exr --ch R=rgba.R,G=rgba.G,B=rgba.B,A=rgba.A --iscolorspace  --ociodisplay:subimages=0 sRGB "ACES 1.0 SDR-video" -o C:\\Users\\desrvc\\AppData\\Local\\Temp\\pyblish_tmp_gz0072s0\\blendertest01_renderLgtMain_beauty.1013_thumb.jpg
2024-11-08 10:59:38:  0: STDOUT: WARNING:pyblish.ExtractThumbnail:Failed to create thumbnail using oiiotool
@BigRoy
Copy link
Contributor

BigRoy commented Nov 8, 2024

A potential fix for this is in this PR here: #67

See the code here

Because there I did end up collecting the colorspace from the configuration set up in the Blender file itself.

@jrsndl
Copy link
Author

jrsndl commented Nov 11, 2024

See the code here

Because there I did end up collecting the colorspace from the configuration set up in the Blender file itself.

The display + view from Blender is cool, thank you!

Just wondering, maybe we should set the colorspace by the Node override, and not display & view?

Image

Imho it would be great to have something like Maya workfile settings, where we can setup default rendering space, together with display and view:

Image

@LiborBatek LiborBatek added the type: bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants