Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vague filenames of generated integrations #11

Open
henhal opened this issue Apr 7, 2022 · 1 comment
Open

Vague filenames of generated integrations #11

henhal opened this issue Apr 7, 2022 · 1 comment

Comments

@henhal
Copy link
Contributor

henhal commented Apr 7, 2022

When generating integrations, each path generates a separate file, called +.yml.
Currently my integrations directory looks like this:

1649255895975104.yml
1649255895976110.yml	
164933241670879.yml

And it's not very clear... Is there a reason for this? Couldn't the files be named <path>.yml - but with slashes transformed into underscores (and the leading slash removed), or something like that? This would make it more intuitive.

paths:
  /foo: # generates foo.yml
    ...
  /foo/bar # generates foo_bar.yml
    ...

Possibly an even better approach would be to generate one file per operation, not one per path, so that they could be named:

getPet.yml
addPet.yml
listPets.yml

Wouldn't this still be possible to deep merge correctly - the x-amazon-apigateway-integration objects are placed inside each operation anyway, right?

Yet another approach could be to generate all integrations into a single file?

If any of this is of interest, I could raise a PR if that's accepted.

@yndlingsfar
Copy link
Owner

Hey, good hint. A PR would be much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants