Remove unsafe 'assert' and replace it with a proper exception #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on some improvements to your script with an eye to integrating it with my open source wallet in the future. One thing I noticed is that on my build environment "assert" is disabled, which leads to bugs because "assert" is not supposed to be used for runtime error checking, only for debug environments. >Assertions should *not* be used to test for failure cases that can occur because of bad user input or operating system/environment failures, such as a file not being found. Instead, you should raise an exception, or print an error message, or whatever is appropriate. One important reason why assertions should only be used for self-tests of the program is that assertions can be disabled at compile time. https://wiki.python.org/moin/UsingAssertionsEffectively So I replaced the assertions with a quick wrapper that works around that bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some improvements to your script with an eye to integrating it with my open source wallet in the future.
One thing I noticed is that on my build environment "assert" is disabled, which leads to bugs because "assert" is not supposed to be used for runtime error checking, only for debug environments.
https://wiki.python.org/moin/UsingAssertionsEffectively
So I replaced the assertions with a quick wrapper that works around that bug.