From 88f2451621e09412a9dfc8cf52a710747b27e757 Mon Sep 17 00:00:00 2001 From: Matt Pulver Date: Tue, 6 Jul 2021 15:15:15 -0400 Subject: [PATCH] Check and simplify hash-join logic --- QueryEngine/JoinHashTable/HashJoin.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/QueryEngine/JoinHashTable/HashJoin.cpp b/QueryEngine/JoinHashTable/HashJoin.cpp index ba74832d0a..e142a7fb13 100644 --- a/QueryEngine/JoinHashTable/HashJoin.cpp +++ b/QueryEngine/JoinHashTable/HashJoin.cpp @@ -623,8 +623,7 @@ InnerOuter normalize_column_pair(const Analyzer::Expr* lhs, auto outer_ti = lhs_ti; auto inner_ti = rhs_ti; const Analyzer::Expr* outer_expr{lhs}; - if ((!lhs_col || (rhs_col && lhs_col->get_rte_idx() < rhs_col->get_rte_idx())) && - (!rhs_col || (!lhs_col || lhs_col->get_rte_idx() < rhs_col->get_rte_idx()))) { + if (!lhs_col || (rhs_col && lhs_col->get_rte_idx() < rhs_col->get_rte_idx())) { inner_col = rhs_col; outer_col = lhs_col; } else {