Load blockmap and LLVM bitcode sections from the ELF binary. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vext01
changed the title
|
Commit message has a typo. Once reviewed, remind me to fix it. |
|
Looks good. You can force push the typo fix now. |
This is to reflect a change in ykllvm. In short, it's not obviously correct for us to add SHF_ALLOC to those sections. For more details see: ykjit#923
vext01
force-pushed
the
dont-alloc-sections
branch
from
97e54aa to
90f5653
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reflect a change in ykllvm. In short, it's not obviously correct for us to add SHF_ALLOC to those sections.
For more details see:
#923
Compiler change
coming soon: #927