Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable lines of code #308

Open
mDeram opened this issue Apr 12, 2022 · 0 comments · May be fixed by #309
Open

Unreachable lines of code #308

mDeram opened this issue Apr 12, 2022 · 0 comments · May be fixed by #309

Comments

@mDeram
Copy link

mDeram commented Apr 12, 2022

Version

v2.0.5

Issue

src/hooks.tsx have unreachable lines of code in return statements. In each hook return statement, this line can never get called:

if (!active) return;

because in the beginning of each useEffect hooks there is the same line. The value of "active" variable does not change in the hook, meaning that "active" is falsy in the beginning of the hook, the hook will return before reaching the last return statement of each hook.

@mDeram mDeram linked a pull request Apr 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant