Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Closure as a valid parameter for ListView::itemViewAttributes. #211

Closed
glpzzz opened this issue Sep 8, 2024 · 0 comments
Closed
Labels
type:feature New feature

Comments

@glpzzz
Copy link
Contributor

glpzzz commented Sep 8, 2024

          > @samdark @vjik what do you think about allowing `ListView::itemViewAttributes()` to also accept a Closure so the `li` (or other item tag) could be customized according to the specific item?

I agree with @samdark. See as example:

private function prepareBodyAttributes(array $attributes, DataContext $context): array

Suggest implement it in separate PR only.

Originally posted by @vjik in #210 (comment)

@vjik vjik added the type:feature New feature label Sep 8, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 8, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 8, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 9, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 9, 2024
@vjik vjik closed this as completed in e9eec42 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants