Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quoter #756

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Refactor Quoter #756

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b259119
Refactor `Quoter`
Tigrov Sep 23, 2023
d9d1ee2
Fix bug with sub-query with alias as table name
Tigrov Sep 25, 2023
b824b71
Fix CI
Tigrov Sep 25, 2023
194aa67
Add Add line to CHANGELOG.md, update test
Tigrov Sep 26, 2023
63bccfb
Update CHANGELOG.md
vjik Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
## 1.1.2 under development

- Bug #751: Fix collected debug actions (@xepozz)
- Enh #756: Refactor Quoter (@Tigrov)
- Bug #756: Fix `quoteSql()` for sql containing table with prefix (@Tigrov)
- Bug #756: Fix `getTableNameParts()` for cases when different quotes for tables and columns (@Tigrov)
- Bug #756: Fix `quoteTableName()` for sub-query with alias (@Tigrov)
vjik marked this conversation as resolved.
Show resolved Hide resolved

## 1.1.1 August 16, 2023

Expand Down
2 changes: 1 addition & 1 deletion tests/Db/Schema/QuoterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function testQuoteSqlWithTablePrefix(): void

public function testQuoteTableNameWithQueryAlias()
{
$quoter = new Quoter('`', '`', 'prefix_');
$quoter = new Quoter('`', '`');
$name = '(SELECT * FROM table) alias';

$this->assertSame($name, $quoter->quoteTableName($name));
Expand Down
Loading