Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $withColumn parameter from getTableNameParts() #757

Closed
Tigrov opened this issue Sep 24, 2023 · 3 comments
Closed

Remove $withColumn parameter from getTableNameParts() #757

Tigrov opened this issue Sep 24, 2023 · 3 comments
Milestone

Comments

@Tigrov
Copy link
Member

Tigrov commented Sep 24, 2023

db/src/Schema/Quoter.php

Lines 87 to 92 in b259119

public function getTableNameParts(string $name, bool $withColumn = false): array
{
$parts = array_slice(explode('.', $name), -2, 2);
return $this->unquoteParts($parts, $withColumn);
}

Suggestion to remove the second parameter of getTableNameParts(string $name, bool $withColumn = false)

Instead, add method getColumnNameParts() if necessary.

@vjik
Copy link
Member

vjik commented Sep 26, 2023

Does getTableNameParts() with $withColumn parameter equal to true somewhere used now?

@Tigrov
Copy link
Member Author

Tigrov commented Sep 28, 2023

In one place https://github.com/yiisoft/db/pull/746/files#diff-697d8c4d18282e94c125fbb9302841ce34c6f6bbe6a4406cd57b371ca9e145aeL470

But it does not work as expected (test #744)

Removed this use in PR #746

@Tigrov
Copy link
Member Author

Tigrov commented Nov 10, 2023

Added to issue #767

@Tigrov Tigrov closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants