From aecde4bf63e273fe304612ed8da555a1c25153ff Mon Sep 17 00:00:00 2001 From: WorldSEnder Date: Fri, 23 Aug 2024 15:53:59 +0200 Subject: [PATCH] Provide reference ref for benchmark action and make it less spammy (#3716) * provide reference ref for benchmark action it's apparently not possible to also provide a PR number for the comment to target, since that is automically determined by the action (and wrong for workflow_run workflows) See also: benchmark-action/github-action-benchmark#250 * guard benchmark action with performance label again This check was removed in #2774 for simplicity, bring it back to spam less --- .github/workflows/benchmark.yml | 1 + .github/workflows/post-benchmark.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 162d76d921b..84c2316f7bb 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -19,6 +19,7 @@ concurrency: jobs: benchmark: + if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'performance') runs-on: ubuntu-latest steps: diff --git a/.github/workflows/post-benchmark.yml b/.github/workflows/post-benchmark.yml index 538795f82bc..2350a74a843 100644 --- a/.github/workflows/post-benchmark.yml +++ b/.github/workflows/post-benchmark.yml @@ -48,3 +48,4 @@ jobs: # Enable job summary summary-always: true comment-always: true + ref: ${{ github.event.workflow_run.head_sha }}