Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger wallet derivation paths missing from yield/earn #255

Open
zenzen-sol opened this issue Feb 6, 2021 · 0 comments
Open

Ledger wallet derivation paths missing from yield/earn #255

zenzen-sol opened this issue Feb 6, 2021 · 0 comments

Comments

@zenzen-sol
Copy link

Description

On the "vault" UI at https://yearn.finance/vaults, the "Connect Wallet" button includes an option for Ledger. When Ledger is selected, the user is asked to choose between different derivation paths on their Ledger Wallet. The user is able to choose a derivation path and make a deposit. (Screenshot below.)

However, if the user switches to the "earn" UI at https://v1.yearn.finance/earn, they are no longer connected to their wallet. If they click the "Connect your wallet" button, and choose Ledger, they are not asked to choose a derivation path. Instead, a default derivation path is chosen for them. If this is a different derivation path from the one chosen in the "vault" UI, then the user's deposit balance will not be available in the "earn" UI.

Steps to reproduce

Steps to reproduce the behavior:

  1. Connect Ledger wallet from https://yearn.finance/vaults and choose a derivation path other than the "default" path.
  2. Deposit funds into a vault from the Ledger wallet.
  3. Switch to https://v1.yearn.finance/earn.
  4. Connect Ledger wallet.
  5. Vault deposits are unavailable, since the second wallet connection is aimed at a different derivation path than the first.

Expected behavior
The "earn" UI at https://v1.yearn.finance/earn would ideally retain the same wallet connection as the "vault" UI at https://yearn.finance/vaults. At the very least, the two UIs should offer the same connection method, including the option to choose a derivation path on the Ledger wallet.

Screenshots
Screen Shot 2021-02-06 at 9 43 05

Versions

  • Browser: Chrome 88.0.4324.96 (Official Build) (x86_64)
@dudesahn dudesahn transferred this issue from yearn/yearn-finance Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant