Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more precise values for dashboard portfolio balance calculation #221

Open
AidanGG opened this issue Dec 23, 2020 · 2 comments
Open

Use more precise values for dashboard portfolio balance calculation #221

AidanGG opened this issue Dec 23, 2020 · 2 comments

Comments

@AidanGG
Copy link

AidanGG commented Dec 23, 2020

The currently used values from the CoinGecko API do not have enough precision. For e.g. the 3pool (https://www.coingecko.com/en/coins/lp-3pool-curve), the value used in the dashboard is the $1.01 at the top of the page which is returned by the API, but the actual virtual price is the $1.0056330001021672 shown at the bottom of the page. This difference in precision is not entirely negligible.
@antonnell
Copy link
Member

I agree, CoinGecko should probably increase the precision that they return, Do you have a more reliable source for the USD price of assets?

@AidanGG
Copy link
Author

AidanGG commented Jan 29, 2021

https://www.curve.fi/3pool/ has it under "Virtual Price" at the full precision when hovered over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AidanGG @antonnell and others